Bug Verified

[MythicItems] Consumable items are breaking in the offhand

#1669 opened by Unknown 5 years ago

Upvote 2
Unknownreported this bug

MYTHICMOBS 4.11.0 MYTHICARIFACTS 0.1.30 TUINITY 1.16.4

Summary

Consumable items (those with consumeUsedItem mechanic) still keep their effects after being consumed. Usually changing item slots works. If you have it in the offhand (like in my case), the consumables keep their effects on the bare hands even if you change the slots.

Steps to reproduce

Example item:

https://pastebin.com/jUNhSG6F

Any item that has an effect and consumeUsedItem will keep the effect after consuming.

Current behavior

I cannot make consumable items AT ALL. It's really impactful.

Intended correct behavior

Skills shouldnt set off when their parent item is not in hand.

Server log file

Don't think it's needed in this case. Can provide if asked.

Debug log snippet

https://pastebin.com/nv1pnQbJ

Proposed fixes

Probably consumeUsedItem mechanic bug. Maybe need additional conditions.

Unknowncommented

I can confirm that - consumeHeldItem{amount=1} is bugged on 1.16.4 .

Unknowncommented

consumeUsedItem works for me correctly on this item, but not on the mentioned in the OP https://pastebin.com/g20svFFM

Unknowncommented

So after further investigation, the item breaks ONLY if used in the OFFHAND (~onRightClick doesn't work when the item is held in the mainhand [since ~onUse launches, and when used ~onUse it works correctly], but removing the ?equipslot{OFFHAND} seems to work good for the ~onSwing}. Everything breaks when used in the offhand, so I guess that's the issue.

Unknowncommented

I can verify this bug with the pastebin provided. The skills that use ~onRightClick are not causing the issue for me. I removed them. The skills using the ~onSwing trigger are causing the issue. The item will be consumed, but everytime you left click afterwards the consumed items skills continue to fire off until you reload the plugin again.

[Legacy attachment omitted]

I also set cooldown to 0 to show the bug more efficiently

Edit: on the newest build of mythic mobs and crucible

MM: 4.11 MythicMobs@9c138e99de9f9a068f1113cf18dd2cf4a27fb3d0

MythCruc: #3543 dev build from 1/11/2021

Sign in to join the discussion.