Bug Closed · Resolved

Parties doesn't work what so ever.

#4869 opened by Unknown 2 years ago

Unknownreported this bug

[18:54:12] [Server thread/INFO]: ItsLunarBruh issued server command: /dungeon play SpaceDungeon [18:54:12] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'dungeon' in plugin MythicDungeons v1.2.2F at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchCommand(CraftServer.java:1009) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at org.bukkit.craftbukkit.v1_20_R1.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:265) ~[axolotl-1.20.1.jar:?] at net.minecraft.commands.Commands.performCommand(Commands.java:324) ~[?:?] at net.minecraft.commands.Commands.performCommand(Commands.java:308) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2374) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$18(ServerGamePacketListenerImpl.java:2334) ~[?:?] at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1364) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.wrapRunnable(MinecraftServer.java:199) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1341) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1334) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1312) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1200) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:326) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.NullPointerException: Cannot invoke "org.bukkit.entity.Player.getUniqueId()" because "player" is null at net.playavalon.mythicdungeons.MythicDungeons.getMythicPlayer(MythicDungeons.java:1731) ~[MythicDungeons-1.2.2.jar:?] at net.playavalon.mythicdungeons.player.party.DungeonParty.<init>(DungeonParty.java:92) ~[MythicDungeons-1.2.2.jar:?] at net.playavalon.mythicdungeons.MythicDungeons.sendToDungeon(MythicDungeons.java:1741) ~[MythicDungeons-1.2.2.jar:?] at net.playavalon.mythicdungeons.MythicDungeons.onCommand(MythicDungeons.java:742) ~[MythicDungeons-1.2.2.jar:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 23 more

When you have the party config set to Parties, it will display that error upon the first time running /dungeons play DUNGNAME.

If you run the command a second time, all seems to work. However, once everyone in the party accepts the queue, it breaks and you get stuck in the queue without joining the dungeon. You're now stuck in queue with no way to leave until the server reboots.

If you happen to use the default party handler that comes with mythic dungeons, that doesn't work either.

The /mythicdungeons:party returns absolutely nothing, and when you're running it side by side with another party plugin, it's required we have that functioning so we can pick which plugin is using /party, and which is using /dparty in commands.yml.

Please either fix Parties support, or make the command /mythicdungeons:party work, along with all sub commands.

Unknowncommented

Hello. You are running Mythic Dungeons version 1.2.2F, which is a free version and the version from before we did an overhaul of the party system. It is highly recommended to update to 1.3.0. Please try the latest version of Mythic Dungeons first and let me know if the problems persist.

Unknowncommented

[21:09:36] [Server thread/INFO]: ItsLunarBruh issued server command: /dungeon play SpaceDungeon [21:09:36] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'dungeon' in plugin MythicDungeons v1.3.1-SNAPSHOT at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchCommand(CraftServer.java:1009) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at org.bukkit.craftbukkit.v1_20_R1.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:265) ~[axolotl-1.20.1.jar:?] at net.minecraft.commands.Commands.performCommand(Commands.java:324) ~[?:?] at net.minecraft.commands.Commands.performCommand(Commands.java:308) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2374) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$18(ServerGamePacketListenerImpl.java:2334) ~[?:?] at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1364) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.wrapRunnable(MinecraftServer.java:199) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1341) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1334) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1312) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1200) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:326) ~[axolotl-1.20.1.jar:git-Axolotl-"3841885"] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.NullPointerException: Cannot invoke "org.bukkit.entity.Player.getUniqueId()" because "player" is null at net.playavalon.mythicdungeons.MythicDungeons.getMythicPlayer(MythicDungeons.java:627) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.api.party.IDungeonParty.initDungeonParty(IDungeonParty.java:63) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.player.party.PartyWrapper.<init>(PartyWrapper.java:67) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.MythicDungeons.sendToDungeon(MythicDungeons.java:640) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.commands.dungeon.MythicDungeonsCommand.handlePlayCommand(MythicDungeonsCommand.java:1221) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.commands.dungeon.MythicDungeonsCommand.onCommand(MythicDungeonsCommand.java:51) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at net.playavalon.mythicdungeons.commands.Command.onCommand(Command.java:39) ~[MythicDungeons-1.3.1-SNAPSHOT.jar:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[axolotl-api-1.20.1-R0.1-SNAPSHOT.jar:?] ... 23 more

Same issue on latest.

Unknowncommented

Hey there. I've implemented a potential fix in the latest dev build. Please give it a try and let me know if the issue persist.

Additionally, I see you're using an unfamiliar server-jar, "axolotl"... is this a personal fork of Paper or Spigot? We don't promise support for every server jar out there, but if the changes aren't too significant it should still be fine, but I want to double-check.

Unknowncommented

Axolotl is a pufferfish fork, which is a fork of paper.

The jar shouldn't be causing issues, I'll try out the new dev build on reboot tonight. Thank you so much I'll keep you updated. Once fixed and fully working, is there a spot to donate for the time spent helping me?

Unknowncommented

Okay, good to know, thanks. We don't fully confirm support for pufferfish but it SHOULD be fine. :)

Don't worry about additional donation, you already purchased the plugin. Thank you for understanding and letting us solve this through the issue-tracker. If there are further errors, let me know and I'll see about patching them ASAP.

Unknowncommented

Thank you, and the previous issue is now fixed, however a new issue has occured. When inside of a party, and you do /dungeon play dungeonname, if other people in party do not have an access token on them, it returns "player doesn't meet this dungeon's requirements!" then, if you run the command again, now it only returns "You're already queued for another dungeon!" and is stuck like this until reboot.

Unknowncommented

Additionally, if the party leader runs /dungeon play DUNGNAME, then the party MEMBER accepts it, if the leader DOES NOT accept, and allows time to run out, it also glitches and gets stuck in a perm loop of "You're already queued for another dungeon". When trying to start a new one.

Unknowncommented

Hey there, check out the latest dev build. Looks like you ran into some edge-cases I missed with a new check that tries to prevent players from starting a new dungeon while awaiting another one.

Unknowncommented

The plugin is now almost perfect, the current issue I'm facing is as follows:

I have 3 players in a party. When the party leader starts a dungeon /dungeon play dungname, it says "Dungeon is now available, ready up to play...

When player 1 (party leader) does /ready, it says (1/3). When player 2 types /ready, it says (2/3).

Then if you just wait, and the timer hits 0, the dungeon does not start. It should start.

Instead the mythicdungeons wants 100% of the players in the party to ready up. This should not be the case.

However many people ready up in that countdown is how many should be sent to the dungeon.

Unknowncommented

Any idea?

Unknowncommented

I can't always respond immediately.

What you're currently encountering is an intended feature; a dungeon will not start unless all players in the party are ready. The system was specifically designed that way. If someone isn't readying up, the party leader can kick the player who didn't ready up and try again.

Unknowncommented

This would then disregard every single use case to the external party plugin.

Players have parties of 30+ members that play at dif times of the day, once a day, once a week, once a month.

Having to kick them everytime you want to dungeon is, a problem..

If this is how it's suppose to be, the plugin is unusable for anything else besides dungeons. Which means I'd need to switch back to the PartyHandler md jar.

I'm fine with this option, however it has it's own bugs.

The initial problem, of /mythicdungeons:party not working. Is this fixable?

Unknowncommented

Hello. I have added plugin config options in the latest dev build that will allow parties to start without all players being ready, as well as an option for toggling if the party leader is required to be present. You can find them under ReadyCheckTime at the plugin config page.

As for the Mythic Dungeons party command, I don't quite follow what the problem is... could you describe what's happening? Is the party command from Mythic Dungeons overriding another plugin?

Sign in to join the discussion.