Bug Closed · Resolved

Support with MMOCore party module

#5234 opened by Unknown 2 years ago

Upvote 0
Unknownreported this bug

Hey, I'm the author of MMOCore,

Our users have been constantly getting the following error message after updating to MythicDungeons 1.3+

[00:32:42 WARN]: [MMOCore] Could not initialize party module: Could not load compatibility with MythicDungeons

The problem is MythicDungeons and MMOCore both soft-depending on each other. On my server, I got MythicDungeons to enable after MMOCore, which caused the error above. Here is the code MMOCore runs on #onEnable():

this.hook = Bukkit.getServer().getServicesManager().load(MythicDungeonsService.class);
        Validate.notNull(hook, "Could not load compatibility with MythicDungeons");

I assume the service manager of MythicDungeons is only registered when MythicDungeons enables, so if MD enables after MMOCore, integration will fail on my end. I'm affraid the only quality fix would be to have some sort of external Vault like API to handle external party plugins.

Unknowncommented

Hi Jules, currently the plan is to change how the MythicDungeons API works anyways to utilize more fluid access rather than requiring the service to be accessed. This would likely be the simplest solution to resolving this issue as it's unique due to the cross-dependency happening.

Unknowncommented

Update to this as I was looking at it again... I seem to have misunderstood your initial problem. This may require a more unique solution. The simplest solution would be for MMOCore to natively support the MythicDungeons' custom party system via the API, and anything else users might want support for. We can work with you directly to ensure compatibility. This would remove our soft-dependency on MMOCore.

The other option would be to go the other way around, where you are not required to soft depend on MythicDungeons at all and we build in functionality for MMOCore. Obviously, the ideal for us would be for MMOCore to take the initiative as MythicDungeons is more specific to a niche rather than an AIO solution, but this can be discussed further. Would you be open to having a conversation on Discord?

Unknowncommented

I'm fine with taking that initiative. MMOCore already supports MythicDungeons builtin party system, I can also have MMOCore provide an interface for MythicDungeons to interact with the MMOCore party system. Let's talk on Discord, my id is jules8588

Unknowncommented

Will be in the next development build.

Sign in to join the discussion.