Bug Closed · Resolved

sharesparty not work and error

#6684 opened by Unknown 10 months ago

Unknownreported this bug

When using the sharesparty condition, damage is dealt to me, my party members, and mobs. If I remove this condition, the only thing that changes is that damage stops being dealt to myself. Previously, even though I was getting error spam in the console (which I provided below), the condition worked correctly. But at some point, it stopped working entirely, and for some reason, it even started dealing damage to me.

EDIT: according to my observations, this problem exists with @EntityInRadius (EIR), but not with @target, for example

EDIT2: PlayerInRadius (PIR) too good work, this problem maybi only for EIR

test_item:
  Id: diamond_sword
  Skills:
  - skill{s=test_skill} @self ~onUse
test_skill:
  Conditions:
  - notinregion{r=spawn} true
  Skills:
  - aura{aura=test_aura;duration=101;i=5;ot=test_aura_skill} @self
test_aura_skill:
  Skills:
  - hit{m=0.4;pk=true;pi=true;triggerskills=true} @EIR{r=10;ignore=armor_stand;conditions=[  - notinregion{r=spawn} true  - sharesparty false ]}

SPAM ERROR:

[16:15:42 WARN]: [MythicMobs] ✗ Configuration Error in Condition CustomCondition
[16:15:42 WARN]: [MythicMobs] --| Error Message: An internal error occurred
[16:15:42 WARN]: [MythicMobs] --| Condition Line: sharesparty false
[16:15:42 WARN]: java.util.NoSuchElementException: No value present
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.bukkit.utils.serialize.Optl.get(Optl.java:98)
[16:15:42 WARN]:        at MythicDungeons-2.0.1-SNAPSHOT 266 .jar//net.playavalon.mythicdungeons.mythic.conditions.SharesDungeonPartyCondition.check(SharesDungeonPartyCondition.java:38)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.SkillCondition.lambda$evaluateTargets$2(SkillCondition.java:332)
[16:15:42 WARN]:        at java.base/java.util.Collection.removeIf(Collection.java:583)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.SkillCondition.evaluateTargets(SkillCondition.java:323)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.targeters.IEntitySelector.filter(IEntitySelector.java:301)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.AbstractSkill.evaluateTargets(AbstractSkill.java:259)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.AbstractSkill.evaluateTargets(AbstractSkill.java:221)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.SkillMechanic.executeSkills(SkillMechanic.java:541)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.SkillMechanic.execute(SkillMechanic.java:505)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.MetaSkill.execute(MetaSkill.java:507)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.MetaSkill.execute(MetaSkill.java:427)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.auras.Aura$AuraTracker.execute(Aura.java:412)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.auras.Aura$AuraTracker.executeAuraSkill(Aura.java:371)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.auras.Aura$AuraTracker.executeAuraSkill(Aura.java:358)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.auras.Aura$AuraTracker.auraTick(Aura.java:615)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.core.skills.auras.Aura$AuraTracker.run(Aura.java:596)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.bukkit.utils.Delegates$RunnableToConsumer.accept(Delegates.java:93)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.bukkit.utils.Schedulers$LumineAsyncTask.run(Schedulers.java:517)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.bukkit.utils.tasks.LumineExecutors$SchedulerWrappedRunnable.run(LumineExecutors.java:70)
[16:15:42 WARN]:        at MythicMobs-5.10.1-SNAPSHOT 5542 .jar//io.lumine.mythic.bukkit.utils.tasks.LumineAsyncExecutor$FixedRateWorker.lambda$run$0(LumineAsyncExecutor.java:186)
[16:15:42 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
[16:15:42 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
[16:15:42 WARN]:        at java.base/java.lang.Thread.run(Thread.java:1583)
Unknowncommented

Hey there. Looks like this is just a small oversight. I've fixed that error message in the latest dev build, but there may still be some quirks with the sharesparty condition. Please give the latest build a try and let me know if you're still having issues.

Unknowncommented

hello. this issue still exists . both party members and mobs are damaged on @EntitiesNearOrigin{r=6;conditions=[ - sharesparty false ]}

Sign in to join the discussion.