Bug Closed · Resolved

Item attribute UUIDs are the same, causing other plugins to have a fit.

#1000 opened by Unknown 5 years ago

Unknownreported this bug

Summary

Item attribute UUIDs that are applied on the items, have the same UUID, and are causing exceptions to be thrown in other plugins. The Example below is with a premium plugin, EpicCraftingPlus.

Steps to reproduce

  1. Download paper-161+ for 1.16.2
  2. Create item in MythicMobs/Items with attributes
  3. Attempt to put said item in a custom crafting recipe via different plugin

Current behavior

Sample Item Config: https://pastebin.com/vCJJpJ5A The Item in game: https://puu.sh/Grdkl/fcba475548.png The Exception being thrown in EpicCraftingsPlus: https://puu.sh/Grdmd/5f2fd78985.png

Intended correct behavior

Each attribute should have different UUIDs, just as the vanilla minecraft summon of give command gives different attributes.

Server log file

I can provide this if needed, but nothing gets thrown into the console, except for the plugins and server starting up.

Debug log snippet

https://pastebin.com/1yavjFPM

Proposed fixes

I honestly have no idea. Admittedly I'm pretty clueless when it comes to code, but if I had to guess, something about the UUID handlers could be mucking this up and causing it to repeat the UUID for each attribute. Changing the attribute UUIDs themselves (just 1 digit) doesn't fix it. The attrubutes themselves work fine on whichever weapons or tools they are on, but for something like QuantumRPG (aka DivineRPG), I feel like this would cause a lot of issues.

Thanks again for all of your incredible work on this.

Unknowncommented

Please see issue #90

Unknowncommented

Ehh, not entirely the same issue.

Items spawned though a vanilla minecraft command work as intended. While I did comment and say this was essentially the problem, it actually isn't entirely. The command I generated was from mapmaking.fr.

/minecraft:give dxultimate minecraft:diamond_sword{AttributeModifiers:[{AttributeName:"generic.armor",Name:"generic.armor",Slot:"mainhand",Amount:10,Operation:0,UUID:[I;1071215457,1071014488,1068585209,1829343798]},{AttributeName:"generic.attack_damage",Name:"generic.attack_damage",Slot:"mainhand",Amount:46,Operation:0,UUID:[I;1071215457,1071014488,1068585209,1829343797]},{AttributeName:"generic.spawn_reinforcements",Name:"generic.spawn_reinforcements",Slot:"mainhand",Amount:5,Operation:0,UUID:[I;1071215457,1071014488,1068585209,1829343796]}]} 1

The item here has one number changed on every single UUID, but it was a manual/forced change. This specific item appears to work with every other plugins as well not causing said issues above.

https://puu.sh/GvhbO/7fdc9a20fe.png

Is it possible to write a UUID generator when an item is summoned via the "mm give" or "mm get" command? This would fix all the fussyness with other plugins and whatnot.

This probably wouldn't be a simple task, but it would work. Even restarting the server and having that mess of NBT's being rewritten/serialized (I think I'm using this right) would still function normally as it did.

Sign in to join the discussion.