TPS Drops related to villagers' vanilla override (I think)

Can you test MM dev build 3954 and 3953? See if the TPS issue happens in either builds.

I can, i'll let you know when I do.

3954 has same issue it seems, https://pastebin.com/4H9aQzZM

3953 gives only a slightly smaller error, but essentially the same just less verbose. All randomspawns do not seem to be working either.

Noteworthy bit is that 8e25ccdf 4.14.1 Premium still has the error, but seems to not affect TPS nearly as badly, at least not noticeably enough. Randomspawns on this version also seems to be acting quite differently. Might have to make a separate issue or hit up the discord on that though

4004 seems to be somewhat related? changelog references a call that is similar in nature. can confirm?

"Double-check that chunk is actually loaded when EntitiesLoadEvent fires"

Are you still getting TPS drops on latest dev?

Still noticeable amounts, not exactly as bad as initially reported. Still getting these errors in console:

25.01 00:07:00 [Server] ERROR [MythicMobs] [EVENTS] Exception thrown whilst handling event: org.bukkit.event.world.EntitiesLoadEvent
25.01 00:07:00 [Server]  java.lang.NullPointerException
25.01 00:07:00 [Server] ERROR [MythicMobs] [EVENTS] Exception thrown whilst handling event: org.bukkit.event.world.EntitiesUnloadEvent
25.01 00:07:00 [Server]  java.lang.NullPointerException
25.01 00:07:00 [Server]  [MythicMobs] ? Config Error for Mob 'VILLAGER' in 'VanillaMobs.yml': Error processing skills for mob VILLAGER. Mob type may no longer exist, or may have become corrupted by a server crash, and will be removed.

Vanillamobs yml

https://pastebin.com/bmiHFXWP

skillyml

https://pastebin.com/m2RuMeJd

I do wonder if i need to delete and regenerate active-mobs after that update tho

Can you test the latest dev build and see if you notice any difference? https://discord.com/channels/213109157983813633/523443579574681600

Console spam is resolved in current dev, Issue with TPS was related to conditional targeters on villager based mob, I'm pretty sure, after testing. Spoke with josh briefly on this, and I might have to change the AI on them a bit perhaps. instead of conditional arguments for a scoreboard check (I assume run on every tick for targeters?) I would likely have a skill to set a players' faction based off of conditions when the value is changed, and have them target that faction. Could get messy so wish me luck. Might be nice to have an interval argument for conditional AITargetSelectors... I might put in a suggestion for it.

Yeah, that's a good idea. Will see if we can implement an interval argument to nearestIf targetselector