Bug Closed · Resolved

Projectile damage modifer does not work correctly

#2681 opened by Unknown 4 years ago

Upvote 1
Unknownreported this bug

I'm sorry that I mention this issue again but this issue is still not resolved. I created a ticket (https://tickettool.xyz/direct?url=https://cdn.discordapp.com/attachments/884495827693871224/947300381732528128/transcript-closed-2132.html) a few days ago and Phil suggested me update the relevant plugins. I've done so as he suggested but the issue still persists. This issue has been existing for a long time mythiccraft/MythicMobs#82 and I hope this time we can truly investigate it and try to fix it. The projectile damage modifier is really important and useful tool to balance the gameplay.

Summary

The projectile damage modifier does not work correctly. Setting a PROJECTILE 0.1 modifier does not reduce the incoming projectile damage. Setting a PROJECTILE 0 modifier does not make the mob immune to the projectile damage. However, the weird thing is that setting a PROJECTILE -5 modifier works as intentded (i.e., projectile damage can heal the mob then).

I have MythicLib/MMOCore/MMOItems installed. I am not sure if it's related to MythicLib/MMOCore/MMOItems.

Steps to reproduce

  1. Install MMOCore 1.9.1, MMOItems 6.7.1, MythicLib 1.3, with fresh config
  2. Install MythicMobs v5.0.0-SNAPSHOT-15c83a3b
  3. Spawn the mob with id "AIM" (see the config I provided)
  4. Use a vanilla bow to shoot the AIM and see the damage

Mobs config: https://pastebin.com/gGWtSCuw

[Legacy attachment omitted]

Current behavior

Setting a PROJECTILE 0.1 modifier does not reduce the incoming projectile damage. Setting a PROJECTILE 0 modifier does not make the mob immune to the projectile damage.

Intended correct behavior

The projectile damage modifier should work as intended.

Server log file

https://pastebin.com/uVBJmw91

Debug log snippet

There are no errors on the console. I use this command to create a villager target to see the damage tho:

[13:47:51 INFO]: Nailm issued server command: /mm mobs spawn AIM

Proposed fixes

Unknowncommented

I can confirm that this bug is caused by MMOItems. I tried:

  1. Installing MythicMobs ------> No bugs
  2. Installing MythicMobs + MythicLib 1.3 ------> No bugs
  3. Installing MythicMobs + MythicLib 1.3 + MMOItems 6.7.1 ------> Bugs happen
Unknowncommented

Should be fixed on the latest MI dev build. This is due to MI overriding bow damage, there used to be a similar issue with Heroes, reopen the MI ticket if it's not but I doubt

Unknowncommented

Hi Jules, thanks for the fix! I tried the latest build but it still doesn't work correctly. There are some new strange behaviors /(ㄒoㄒ)/~~

I will list them case by case.

Case 1: partialy works correctly

Setting a PROJECTILE 5 modifier (which should amplify the damage) seems working correctly, but the damage it deals is not constant (I'm sure the force of bow is full whenever I shoot the arrow). Is the floating damage an intended behavior?

[Legacy attachment omitted]

Case 2: does not work correctly

Setting a PROJECTILE 0.1 modifier (which should weaken the damage) does not work correctly. It does not reduce the damage but slightly increase the damage instead (seems the PROJECTILE 0.1 modifier is acting like PROJECTILE 1.1 modifier, see the screenshot). The floating damage occurs in this case as well.

[Legacy attachment omitted]

Case 2 continued - setting a PROJECTILE 0.9 modifier (the floating damage occurs in this case as well):

[Legacy attachment omitted]

Case 3: does not work correctly

Setting a PROJECTILE 0 modifier (which should be immune to the damage) does not work. The damage is as it is.

[Legacy attachment omitted]

Case 4: works correctly

Setting a PROJECTILE -1 modifier (which heals the mob) works correctly.

Sign in to join the discussion.