Attributes not changing with Netherite #3414

Unknownreported this bug

Sep 16, 2022 at 10:33 AM

Summary

Describe the bug encountered in detail.

When upgrading diamond weapons, armor and tools with custom attributes such as Health and MovementSpeed with netherite ingots, the stats that should be increased do not change.

Steps to reproduce

Provide a full set of steps used to reproduce the bug, including links to SEPARATE Pastebin pastes for each relevant configuration file.

Step 1: Create an item with custom attributes (must be a diamond weapon, tool or armor)

https://pastebin.com/XSEq6SbD

Step 2: Get the item via /mm i get testbom

Step 3: Place a smithing table, get a netherite ingot and upgrade the custom item

Current behavior

Describe what happens currently, while the bug is affecting your server.

When upgrading diamond equipment that have custom attributes with netherite, attributes like AttackDamage and ArmorToughness don't increase.

Intended correct behavior

Describe what you think should happen instead of the bug.

Upgrading items with custom attributes should add the stats of their netherite counterpart (For example if I upgrade a diamond sword, the AttackDamage should be increased by +1)

Server log file

Provide a link to a Pastebin paste with a copy of your server's latest.log file from startup to "Done!" AND includes a player connecting.

https://pastebin.com/tw9rnAzG

Debug log snippet

Provide a link to a Pastebin paste with an excerpt of your latest.log file that includes debug output where you trigger the bugged behavior.

The issue is not server related, instead happens because of an issue of the game.

Proposed fixes

Describe what you think the issue or any potential fixes may be.

So, I was thinking of adding a "custom smithing stone" creator that allows to create a special item that when combined in a smithing table with a piece of equipment it will add the attributes specified in the smithing stone's config.

For example I create a smithing stone that adds +2 AttackDamage and +1 KnockbackResistance to MainHand attributes, when combining a diamond sword with this stone. the sword will have +9 AttackDamage and +1 KnockbackResistance when held in the main hand.

Here is the bug in game:

[Legacy attachment omitted]

Unknowncommented

3 years ago

That is normal vanilla behaviour.

Unknowncommented

10 months ago

That actually sounds like a solid approach — giving players creative control through a configurable smithing stone would make upgrades far more dynamic. When I was debugging something similar for a side project, I remember feeling completely stuck and decided to take a quick break at spinmama, an online casino offering exclusive bonuses for players from England. After a few small spins, a bit of luck turned things around, and I came back with a clearer mind to finish my code. It’s surprising how stepping away for a while — especially with something fun — can help you spot solutions you’d been missing.

Core Plugins