AI Goal Selectors broken for some mobs

Similar bug: FollowRange and ThreatTable can't be used same time. Mobs are freeze 1 second when entering FollowRange and start walking after.

Example for this:

test_1:
  Type: ZOMBIE
  Health: 1000
  Damage: 1
  Faction: test
  AIGoalSelectors:
  - clear
  - meleeattack
  - randomstroll
  - randomlookaround
  AITargetSelectors:
  - clear
  - players
  Options:
    Silent: true
    Despawn: true
    FollowRange: 5
    PreventOtherDrops: true
    PreventItemPickup: true
    KnockbackResistance: 1.0
    PreventMobKillDrops: true
    NoDamageTicks: 1
  Modules:
    ThreatTable: true

https://www.youtube.com/watch?v=prH8GBMDZFk

A lot of vanilla mobs are hardcoded and can't have their AI modified, however skeletons and wither skeletons should work just fine and I'm unable to replicate them not working.

)Threat Tables not obeying follow range is something we can fix

After debugging for hours finally found the what is triggering this bugs.

Skeleton: If skeleton have bow in hand clear working. If skeleton have anything except bow in any of the hands clear stopped working. Even give sword 3 sec delay is same. When the mob get the sword starting the fight. Mob rewrite its own Ai Goal table when get anything in hands. PreventRandomEquipment: true is trigger this bug because mob spawn without bow if Equipment is not set as bow.

Wither Skeleton: Same rules apply but any sword.

Stray: Same as Skeleton

Triggering this bug and use - meleeattack same time trigger freezing mob bug. meleeattack should not be used if first bug trigger.

About ThreatTable

PLEASE do not fix like that. This will completely break ThreatTable mobs. Let me explain. We are using FollowRange as mob aggro to player. ThreatTable mobs doesn't have settings lose aggro to player except ThreatTable rules. ThreatTable mobs should never lose aggro to player except ThreatTable rules, spawner leash reset. If you make ThreatTable obeying FollowRange this will break all mobs because lose aggro will obey this to. Mobs will stop when player go out FollowRange same as non-ThreatTable mobs. ThreatTable is completely meaningless in this case.

If you split lose aggro from FollowRange and add new settings to ThreadTable options will be nice solution. Or just fix the freezing issue ? If not please do no make TT obeying follow range, leave like this. If we not set Follow range leave as mob default not trigger this freeze bug.

More info about AI Goal

When adding 5 tick delay clear is working.

- runaigoalselector{goal=clear;delay=5} @self ~onSpawn

Adding meleeattack always broke mob ai (freezee not attacking mob bug)

- runaigoalselector{goal=meleeattack;delay=20} @self ~onSpawn

Only solution for now never use meleeattack if mob using anything other than bow because mob add itself this goal auto. When we add meleeattack to mob will have 2x meleeattack and they cancel each other/make mob freezee. This is my best guess cause of this bug.

If this is minecraft limitation and cannot be fixed add warning in the wiki will be nice for other users.

Edit: After more testing: Any of usage of AIGoal break the mob ai fully(even delayed clear and add another ai goal ). Mob will stuck between meleeattack and other aigoals.

  - runaigoalselector{goal=clear;delay=5} @self ~onSpawn
  - runaigoalselector{goal=randomlookaround;delay=7} @self ~onSpawn
  - equip{item=sword_one:5;delay=10} @self ~onSpawn

Using like this make mob stuck between meleeattack and randomlookaround while fighting players. https://www.youtube.com/watch?v=qBFmv4XH1rM

I haven't had any luck replicating this. The following config works as intended:

TestAISkeletonMelee:
  Type: SKELETON
  Display: Skeleton Melee Test
  Equipment:
  - iron_sword HAND
  AIGoalSelectors:
  - clear
  - meleeattack
  - randomstroll
  AITargetSelectors:
  - clear
  - players

The skeleton will attack me with its sword, or randomly walk around if not in combat.

To be comprehensive I also tested this:

WeaponSwapTest:
  Type: SKELETON
  Display: 'Testing Dummy'
  Equipment:
  - iron_sword HAND
  AIGoalSelectors:
   - clear
   - 1 meleeattack
  AITargetSelectors:
   - clear
   - players
  Skills:
   - skill{cooldown=16;s=[
       - equip{item="bow HAND"}
       - runaigoalselector{goal=clear}
       - runaigoalselector{goal=1 bowmaster}
       - delay 160
       - equip{i="iron_sword HAND"}
       - runaigoalselector{goal=clear}
       - runaigoalselector{goal=1 meleeattack}
     ]} @self ~onTimer:20 ?incombat

This mob will swap back and forth between using melee and ranged attacks as expected, and if I throw in other goals they seem to work fine

I tested your first config my local and another user online server both are same. Mob is freezing and attack speed is so slow if you do not touch to keyboard.

My Local server Stable 5.2 version: https://www.youtube.com/watch?v=LFG_TawnsXs

Another user server(MM is One of the 5.2 dev version): https://www.youtube.com/watch?v=jd5RVJEjfHk

Since Skeleton is problematic, I thought of replacing it with Piglin, but that is also problematic.

1. Can't clear AI goal or add any default goals. Mechanic doesn't work either. Add custom MM Goal working (fleeConditional)

2. Can't clear or add target to AITargetSelectors. Add custom MM Target Not working (SpecificFaction my_faction_name)

Piglin is AI hardcoded mob ?

TestAIPiglinMelee:
  Type: Piglin
  Display: Piglin Melee Test
  Equipment:
  - iron_sword HAND
  AIGoalSelectors:
  - clear
  #- meleeattack
  #- randomstroll
  AITargetSelectors:
  - clear
  #- players