Bug Closed · Resolved

Premium MythicMobs 5.3.5 incompatibility with shopkeepers and citizens

#4145 opened by Unknown 3 years ago

Upvote 2
Unknownreported this bug

I am encountering issues while using shopkeepers along with MythicMobs. I am trying to put items such as weapons in the shopkeeper inventory but upon reverts back to before I put items in it.

Someone that assisted me believes that MythicMobs cannot correctly handle CreatureSpawnEvent which leads to exceptions when citizen is trying to manually spawn entities using NMS. The entity may not be recognized by spigot and thus not saved into the world folder.

Is it possible that you can patch this and add support for putting items in shopkeeper inventory? thx

Unknowncommented

Bump.
I got same issue when loading with Citizens 2.0.32 (ALPHA 1.20.1 #3) on Paper 1.16.5

[09:29:27 ERROR]: [MythicMobs] [EVENTS] Exception thrown whilst handling event: org.bukkit.event.entity.CreatureSpawnEvent
[09:29:27 WARN]: java.lang.NullPointerException: Cannot invoke "net.minecraft.server.v1_16_R3.SpawnerCreature$d.b()" because "spawnState" is null
[09:29:27 WARN]:        at io.lumine.mythic.core.volatilecode.v1_16_R3.VolatileSpawningHandlerImpl.getSpawnState(VolatileSpawningHandlerImpl.java:43)
[09:29:27 WARN]:        at io.lumine.mythic.core.spawning.random.RandomSpawnerManager.getSpawnState(RandomSpawnerManager.java:269)
[09:29:27 WARN]:        at io.lumine.mythic.core.spawning.random.RandomSpawnerManager.handleSpawnEvent(RandomSpawnerManager.java:231)
[09:29:27 WARN]:        at io.lumine.mythic.bukkit.listeners.MobListeners.lambda$load$5(MobListeners.java:175)
[09:29:27 WARN]:        at io.lumine.mythic.bukkit.utils.Delegates$ConsumerToBiConsumerSecond.accept(Delegates.java:144)
[09:29:27 WARN]:        at io.lumine.mythic.bukkit.utils.events.functional.single.EventListener.execute(EventListener.java:131)
[09:29:27 WARN]:        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
[09:29:27 WARN]:        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[09:29:27 WARN]:        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:624)
[09:29:27 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:734)
[09:29:27 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.event.CraftEventFactory.doEntityAddEventCalling(CraftEventFactory.java:652)
[09:29:27 WARN]:        at net.minecraft.server.v1_16_R3.WorldServer.addEntity0(WorldServer.java:1906)
[09:29:27 WARN]:        at net.minecraft.server.v1_16_R3.WorldServer.addEntity(WorldServer.java:1807)
[09:29:27 WARN]:        at net.citizensnpcs.nms.v1_16_R3.util.NMSImpl.addEntityToWorld(NMSImpl.java:358)
[09:29:27 WARN]:        at net.citizensnpcs.util.NMS.addEntityToWorld(NMS.java:75)
[09:29:27 WARN]:        at net.citizensnpcs.npc.AbstractEntityController.spawn(AbstractEntityController.java:55)
[09:29:27 WARN]:        at net.citizensnpcs.npc.CitizensNPC.spawn(CitizensNPC.java:321)
[09:29:27 WARN]:        at net.citizensnpcs.npc.CitizensNPC.load(CitizensNPC.java:185)
[09:29:27 WARN]:        at net.citizensnpcs.api.npc.SimpleNPCDataStore.loadInto(SimpleNPCDataStore.java:59)
[09:29:27 WARN]:        at net.citizensnpcs.Citizens$CitizensLoadTask.run(Citizens.java:632)
[09:29:27 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100)
[09:29:27 WARN]:        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468)
[09:29:27 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1083)
[09:29:27 WARN]:        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:293)
[09:29:27 WARN]:        at java.base/java.lang.Thread.run(Thread.java:831)
Unknowncommented

Got two more reports for this. This is a thing.

Unknowncommented

Here is an error log of a similar occurance:

[20:27:18 ERROR]: [MythicMobs] [EVENTS] Exception thrown whilst handling event: org.bukkit.event.entity.CreatureSpawnEvent
[20:27:18 WARN]: java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.SpawnerCreature$d.a()" because "spawnState" is null
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.core.volatilecode.v1_18_R2.VolatileSpawningHandlerImpl.getSpawnState(VolatileSpawningHandlerImpl.java:89)
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.core.spawning.random.RandomSpawnerManager.getSpawnState(RandomSpawnerManager.java:269)
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.core.spawning.random.RandomSpawnerManager.handleSpawnEvent(RandomSpawnerManager.java:231)
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.bukkit.listeners.MobListeners.lambda$load$5(MobListeners.java:172)
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.bukkit.utils.Delegates$ConsumerToBiConsumerSecond.accept(Delegates.java:144)
[20:27:18 WARN]:        at MythicMobs-5.4.0-SNAPSHOT_4628.jar//io.lumine.mythic.bukkit.utils.events.functional.single.EventListener.execute(EventListener.java:131)
[20:27:18 WARN]:        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76)
[20:27:18 WARN]:        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[20:27:18 WARN]:        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:671)
[20:27:18 WARN]:        at org.bukkit.craftbukkit.v1_18_R2.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:748)
[20:27:18 WARN]:        at org.bukkit.craftbukkit.v1_18_R2.event.CraftEventFactory.doEntityAddEventCalling(CraftEventFactory.java:653)
[20:27:18 WARN]:        at net.minecraft.server.level.WorldServer.addEntity(WorldServer.java:1506)
[20:27:18 WARN]:        at net.minecraft.server.level.WorldServer.addFreshEntity(WorldServer.java:1415)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.nms.v1_18_R2.util.NMSImpl.addEntityToWorld(NMSImpl.java:353)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.util.NMS.addEntityToWorld(NMS.java:62)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.AbstractEntityController.spawn(AbstractEntityController.java:55)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC.spawn(CitizensNPC.java:311)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC.spawn(CitizensNPC.java:275)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.trait.HologramTrait.createHologram(HologramTrait.java:92)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.trait.HologramTrait.access$200(HologramTrait.java:38)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.trait.HologramTrait$HologramLine.spawnNPC(HologramTrait.java:404)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.trait.HologramTrait.onSpawn(HologramTrait.java:206)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC$1.accept(CitizensNPC.java:371)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC$1.accept(CitizensNPC.java:335)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC.spawn(CitizensNPC.java:416)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.npc.CitizensNPC.load(CitizensNPC.java:180)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.api.npc.SimpleNPCDataStore.loadInto(SimpleNPCDataStore.java:59)
[20:27:18 WARN]:        at Citizens-2.0.30-b2891.jar//net.citizensnpcs.Citizens$CitizensLoadTask.run(Citizens.java:606)
[20:27:18 WARN]:        at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101)
[20:27:18 WARN]:        at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483)
[20:27:18 WARN]:        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1189)
[20:27:18 WARN]:        at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:321)
[20:27:18 WARN]:        at java.base/java.lang.Thread.run(Thread.java:833)

Ran into this assisting another user.

Unknowncommented

Closing due to inactivity and major version changes. If this is still a present issue on modern versions, re-open this issue with a modern-version server log and an updated steps to reproduce.

Sign in to join the discussion.