Suggestion Closed · Implemented

isCitizenNPC taking too much time on projectiles

#5930 opened by Unknown 1 year ago

Unknownreported this suggestion

Summary

isCitizenNPC check on projectiles are taking too much time even tough there's no Citizens plugin to check from.

Steps to reproduce

  1. Have many (any) projectile type
  2. Will be visible in spark

Current behavior

isCitizenNPC on any projectile type taking too much time even tough the server in question does not have Citizens plugin to begin with.

Intended correct behavior

If server does not have any Citizens plugin, the check should not happen.

Server log file

[Legacy attachment omitted]

Proposed fixes

Either a check on startup to disable the check logic or a toggle in config.

Unknowncommented

@Taiyou06 have your optimization contributions accounted for this yet?

Unknowncommented

Ah this is fixed by @ashijin

Sign in to join the discussion.