Bug Verified

modDamageType not work in onDamaged aura

#6146 opened by Unknown 1 year ago

Upvote 0
Unknownreported this bug
BugReport1:
  Skills:
  - onDamaged{
      auraName=br1;
      d=300;
      rd=false;
      i=1;
      bt=true;
      damagetype=ENTITY_ATTACK;
      oD=[
        - m{m="It's EntityAttack!!"} @Self
      ]} @Self

As intended, this aura skill should only activate upon receiving ENTITY_ATTACK damage, but in reality, it triggers upon any form of damage.

Unknowncommented

Closing due to lack of server log, versions, or additional environment information needed to reproduce. If this issue is still present, re-open this issue with a modern-version, complete server startup log and steps used to test and confirm the behavior.

Unknowncommented

In Dev 5384, this bug still exists the backend shows no errors, but the core issue is that the moddamagetype option does not work as documented. the skill under onhit still triggers unconditionally even when moddamagetype is specified.

Unknowncommented

#1724 also is confirmed as a Damage Modifier related issue present

Unknowncommented

Discord Ticket also confirms similar behavior for onDamaged Damage Modifiers simply not working:

  - onDamaged{
      auraName=ShamanElixirAuraEffect2;d=1140;
      onTick=[
        - particles{p=End_Rod;a=5;hS=.5;vS=.5;s=.01;y=1}
      ];
      damageMods="FIRE 0, FIRE_TICK 0, CAMPFIRE 0, MAGIC 0, WITHER 0, PROJECTILES 0, THORNS 0"} @self

some console errors seem present:

[20:14:10 WARN]: [MythicMobs] ? Configuration Error in Mechanic ondamaged
[20:14:10 WARN]: [MythicMobs] --| Skill: ShamanElixirofLifeActivate | File: /home/container/plugins/MythicMobs/packs/Gnome/skills/class/shaman-item-skills.yml
[20:14:10 WARN]: [MythicMobs] --| Error Message: Invalid syntax for DamageModifier
[20:14:10 WARN]: [MythicMobs] --| Mechanic Line: onDamaged{Interval=20;repeat=50;<&csp>auraName=ShamanElixirAuraEffect2;d=1140;<&csp>onTick=[<&csp><&da><&csp>particles{p=End_Rod;a=3;hS=.5;vS=.5;s=.01;y=1}<&csp>];<&csp>damageMods="FIRE<&sp>.001<&cm><&sp>FIRE_TICK<&sp>.001<&cm><&sp>CAMPFIRE<&sp>.001<&cm><&sp>MAGIC<&sp>.001<&cm><&sp>WITHER<&sp>.001<&cm><&sp>PROJECTILE<&sp>.001<&cm><&sp>THORNS<&sp>.001"}
[20:14:10 WARN]: java.lang.NumberFormatException: For input string: "FIRE_TICK"
[20:14:10 WARN]:        at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
[20:14:10 WARN]:        at java.base/jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
[20:14:10 WARN]:        at java.base/java.lang.Double.parseDouble(Double.java:792)
[20:14:10 WARN]:        at java.base/java.lang.Double.valueOf(Double.java:755)
[20:14:10 WARN]:        at MythicMobs-5.8.2.jar//io.lumine.mythic.core.skills.mechanics.OnDamagedMechanic.modVanillaDamage(OnDamagedMechanic.java:136)
[20:14:10 WARN]:        at MythicMobs-5.8.2.jar//io.lumine.mythic.core.skills.mechanics.OnDamagedMechanic.calculateDamage(OnDamagedMechanic.java:121)
[20:14:10 WARN]:        at MythicMobs-5.8.2.jar//io.lumine.mythic.core.skills.mechanics.OnDamagedMechanic$Tracker.lambda$auraStart$11(OnDamagedMechanic.java:340)
[20:14:10 WARN]:        at MythicMobs-5.8.2.jar//io.lumine.mythic.bukkit.utils.Delegates$ConsumerToBiConsumerSecond.accept(Delegates.java:144)
[20:14:10 WARN]:        at MythicMobs-5.8.2.jar//io.lumine.mythic.bukkit.utils.events.functional.single.EventListener.execute(EventListener.java:131)
[20:14:10 WARN]:        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
[20:14:10 WARN]:        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[20:14:10 WARN]:        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
[20:14:10 WARN]:        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131)
[20:14:10 WARN]:        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.callEvent(CraftEventFactory.java:276)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:1207)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:1197)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:1127)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:1090)
[20:14:10 WARN]:        at org.bukkit.craftbukkit.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:1251)
[20:14:10 WARN]:        at net.minecraft.world.entity.LivingEntity.handleEntityDamage(LivingEntity.java:2421)
[20:14:10 WARN]:        at net.minecraft.world.entity.LivingEntity.hurtServer(LivingEntity.java:1522)
[20:14:10 WARN]:        at net.minecraft.world.entity.player.Player.hurtServer(Player.java:957)
[20:14:10 WARN]:        at net.minecraft.server.level.ServerPlayer.hurtServer(ServerPlayer.java:1466)
[20:14:10 WARN]:        at net.minecraft.world.entity.Entity.hurtOrSimulate(Entity.java:2407)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.AbstractArrow.onHitEntity(AbstractArrow.java:480)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.Projectile.onHit(Projectile.java:387)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.Projectile.hitTargetOrDeflectSelf(Projectile.java:346)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.Projectile.preHitTargetOrDeflectSelf(Projectile.java:314)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.AbstractArrow.preHitTargetOrDeflectSelf(AbstractArrow.java:356)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.AbstractArrow.stepMoveAndHit(AbstractArrow.java:312)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.AbstractArrow.tick(AbstractArrow.java:274)
[20:14:10 WARN]:        at net.minecraft.world.entity.projectile.Arrow.tick(Arrow.java:76)
[20:14:10 WARN]:        at net.minecraft.server.level.ServerLevel.tickNonPassenger(ServerLevel.java:1305)
[20:14:10 WARN]:        at net.minecraft.world.level.Level.guardEntityTick(Level.java:1489)
[20:14:10 WARN]:        at net.minecraft.server.level.ServerLevel.lambda$tick$4(ServerLevel.java:812)
[20:14:10 WARN]:        at net.minecraft.world.level.entity.EntityTickList.forEach(EntityTickList.java:39)
[20:14:10 WARN]:        at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:794)
[20:14:10 WARN]:        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1875)
[20:14:10 WARN]:        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1664)
[20:14:10 WARN]:        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1329)
[20:14:10 WARN]:        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:340)
[20:14:10 WARN]:        at java.base/java.lang.Thread.run(Thread.java:1583)
Sign in to join the discussion.