Bug Open

Item conditions only checking MMOItems itemtype

#6462 opened by Unknown 1 year ago

Upvote 3
Unknownreported this bug

Summary

Item conditions (hasitem, itemissimilar, holding etc.) only checks for a given MMOItems itemtype, rather than the full ID.

Steps to reproduce

Create any two MMOItems of itemtype X. Give yourself the second item and hold it in your hand Run any skill with a condition that checks for specifically the first item (i.e - holding{i=mmoitems.X.1})

Current behavior

MMOItems of the same itemtype, but differing IDs both satisfy item conditions. So holding either a mmoitems.GUN.GLOCK or mmoitems.GUN.AK would satisfy holding{i=mmoitems.GUN.GLOCK}

Intended correct behavior

Only MMOItems of the same itemtype and same ID should satisfy those conditions.

Relevant files

Server log: https://mclo.gs/6FwjAli

[Legacy attachment omitted] [Legacy attachment omitted] [Legacy attachment omitted]

Unknowncommented

Can confirm same Problem for me in newest DEV version.

we use "- holding{m=mmoitems.GEM_STONE.RUBY;} castInstead coal_ore_hit_gold"

we can use every item that is in "mmoitems.GEM_STONE" to complete the conditions.

Unknowncommented

Same Problem here, only checks the namespace, not the key

Unknowncommented

got this answer from the support channel: Ohh, if it stopped working, then well, I doubt it will get fixed, as mmoitems stuff is no longer working with MythicCraft, they went on their own way.

Unknowncommented

Been having the same problem I know they don’t support but it’ll be real nice since you can create custom skills with MythicMobs and integrate it over

Unknowncommented

This is an issue between 2 plugins.

Sign in to join the discussion.