Bug Open

BUG : FANCY drops stop working when RequiredDamagePercent is above 1

#6919 opened by Unknown 6 months ago

Unknownreported this bug

Summary

RequiredDamagePercent stops drops from working when set to any value > 1 while using DropMethod: FANCY with PerPlayerDrops: true (and ClientSideDrops: true). With RequiredDamagePercent: 10, no drops spawn at all. The exact same mob drops correctly when RequiredDamagePercent is set to 0 or 1.

Environment: Leaf 1.21.8 (MC 1.21.8), MythicMobsPremium 5.11.2

Steps to reproduce

1 - Create a separate mob config file (e.g. FancyDrop-TopTest.yml) containing the mob below, then reload MythicMobs.

Mob config (Pastebin): https://pastebin.com/bXG1pfK1

2 - Spawn FancyDrop-TopTest.

3 - Have at least 2 players damage the mob, then kill it.

4 - Observe that with RequiredDamagePercent: 10, no items drop.

5 - Change only RequiredDamagePercent: 10 to RequiredDamagePercent: 1 (or 0), reload MythicMobs, and repeat the test.

6 - Observe that drops work again when the value is 0 or 1.

Current behavior

  • With RequiredDamagePercent: 10 (or any value > 1 tested): no drops for any player.
  • With RequiredDamagePercent: 1 or 0: FANCY drops work as expected.

Intended correct behavior

RequiredDamagePercent: 10 should require players to deal at least 10% of the mob’s total damage to be eligible for drops (then apply the top=1/2/3 logic normally).

Sign in to join the discussion.