Bug Verified

Error with MM Items / Mob Drops

#907 opened by Unknown 6 years ago

Unknownreported this bug

Summary

It seems that there is a bug concerning MythicMobs Items (so impacting custom mob drops). Every things that are concerning items is simply not working.

Steps to reproduce

I personaly used my items files which were working in 1.15 version and did /mm items give .

But I think you can simply create an item (even basic) and try to make a mob dropping it or trying to get it from MythicMobs give command.

Current behavior

In game, I got the message "An internal error occured while attempting to perform this command" and I get in console :

[13:50:28] [Server thread/INFO]: Damien0503 issued server command: /mm items give Damien0503 AgriBoots [13:50:28] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'mm' in plugin MythicMobs v4.10.0-SNAPSHOT-SNAPSHOT at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.16.2.jar:git-Paper-141] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.16.2.jar:git-Paper-141] at org.bukkit.craftbukkit.v1_16_R2.CraftServer.dispatchCommand(CraftServer.java:800) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.PlayerConnection.handleCommand(PlayerConnection.java:1907) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.PlayerConnection.a(PlayerConnection.java:1718) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:23) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.TickTask.run(SourceFile:18) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.MinecraftServer.ba(MinecraftServer.java:1135) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.MinecraftServer.executeNext(MinecraftServer.java:1128) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:95) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.MinecraftServer.a(MinecraftServer.java:1264) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:999) ~[patched_1.16.2.jar:git-Paper-141] at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.2.jar:git-Paper-141] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_265] Caused by: java.lang.NullPointerException at io.lumine.xikage.mythicmobs.items.MythicItem.generateItemStack(MythicItem.java:439) ~[?:?] at io.lumine.xikage.mythicmobs.commands.items.GiveCommand.onCommand(GiveCommand.java:86) ~[?:?] at io.lumine.xikage.mythicmobs.utils.commands.Command.onCommand(Command.java:64) ~[?:?] at io.lumine.xikage.mythicmobs.utils.commands.Command.onCommand(Command.java:55) ~[?:?] at io.lumine.xikage.mythicmobs.utils.commands.Command.onCommand(Command.java:55) ~[?:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.16.2.jar:git-Paper-141] ... 18 more

And if I try to kill a mob, nothing it dropped.

Intended correct behavior

Uh... items should be gave / dropped ? :D

Server log file

https://pastebin.com/KebCrfYF

Proposed fixes

I think I am not able to do this...

Unknowncommented

Im having the same error, IM using latest MMOitems and MM build on Paper 1.14.4 (bc I still got other plugins who need to be updated) the item drop is a core feature for my server, which I really need to make it work, I'd really like if they could priotize the item drops.

Unknowncommented

Same issue here.

Latest 1.16.2 paper, latest MM dev build.

Unknowncommented

In the provided logs, it's saying you're using a version of MM that isn't compatible with 1.16.2?

[11:57:48] [Server thread/WARN]: [MythicMobs] This version of MythicMobs is not fully compatible with your version of Bukkit.
[11:57:48] [Server thread/WARN]: [MythicMobs] Some features may be limited or disabled until you use a compatible version.```
Unknowncommented

Yes, but I'am using latest devbuild (3432 and then 3434 since this morning and there is still the same issue)

Unknowncommented

This should be resolved in build 3435

Unknowncommented

Not fixed

Unknowncommented

still having issues

Unknowncommented

I reopened this issue which is still happening.

Unknowncommented

Tried latest dev build, so I can approve, even default drop is not working (via /mm i get )

Unknowncommented

Apologies, something seems to be broken with the build bot and it did not push the appropriate changes to the website. My local builds definitely have this fixed. Should have a resolution shortly.

Unknowncommented

This issue should be fixed in the latest build. Please try it and reopen the issue if you encounter more problems!

Unknowncommented

fixed

Unknowncommented

@ashijin Something still wrong, items can't be stacked with items dropped from prev. version Nothing changed in config https://youtu.be/-Vrph8iJ7Nc <--- demo what happend

https://pastebin.ubuntu.com/p/mRmck5nRdG/ <--- item configuration

Also new items cant be used as trade currency anymore (via Shopkeepers plugin) Item name, lore and NBT tags count is similar.

Unknowncommented

[Legacy attachment omitted]

Using powerNBT plugin I've found the diff in display.Name NBT tag 2 similar items, first generated in MM 4.9.1 and second one in from 4.10 dev build

I think now I should replace all my items.

Unknowncommented

The change in NBT values is an unfortunate side-effect of the new 1.16 text formatting to support all the new colors

Unknowncommented

I am still having this issue too.

  • MM Build #: 3456
  • PaperMC Version:1.16.4 #275

I create the following item in Items/items.yml:

RedLeatherChestplate:
  Id: 298
  Data: 0
  Options:
    Color: 255,0,0

And then here's the error I'm getting:

Nov 15 20:19:35 instance-1 java[11399]: [20:19:35 INFO]: player issued server command: /mm items give player RedLeatherChestplate
Nov 15 20:19:35 instance-1 java[11399]: [20:19:35 ERROR]: null
Nov 15 20:19:35 instance-1 java[11399]: org.bukkit.command.CommandException: Unhandled exception executing command 'mm' in plugin MythicMobs v4.10.1-3456
Nov 15 20:19:35 instance-1 java[11399]:         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchCommand(CraftServer.java:802) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PlayerConnection.handleCommand(PlayerConnection.java:2007) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PlayerConnection.c(PlayerConnection.java:1818) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:1771) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:23) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.TickTask.run(SourceFile:18) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.MinecraftServer.bb(MinecraftServer.java:1136) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.MinecraftServer.executeNext(MinecraftServer.java:1129) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:95) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1265) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1000) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         at java.lang.Thread.run(Thread.java:834) [?:?]
Nov 15 20:19:35 instance-1 java[11399]: Caused by: java.lang.NullPointerException
Nov 15 20:19:35 instance-1 java[11399]:         at io.lumine.xikage.mythicmobs.items.MythicItem.generateItemStack(MythicItem.java:443) ~[?:?]
Nov 15 20:19:35 instance-1 java[11399]:         at io.lumine.xikage.mythicmobs.commands.items.GiveCommand.onCommand(GiveCommand.java:86) ~[?:?]
Nov 15 20:19:35 instance-1 java[11399]:         at io.lumine.xikage.mythicmobs.utils.commands.Command.onCommand(Command.java:64) ~[?:?]
Nov 15 20:19:35 instance-1 java[11399]:         at io.lumine.xikage.mythicmobs.utils.commands.Command.onCommand(Command.java:55) ~[?:?]
Nov 15 20:19:35 instance-1 java[11399]:         at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.16.4.jar:git-Paper-275]
Nov 15 20:19:35 instance-1 java[11399]:         ... 19 more

This occurs for any and all items.

Unknowncommented

I found the issue was because the latest free version of MM is not compatible with 1.16.4. I purchased the premium version and used the latest dev version which solved the problem.

It may be useful to users to communicate which MM versions are compatible with which MC versions.

Sign in to join the discussion.